Literally 5 days left on my account over how locks were treated in Shadowlands.
They made a bad wrath version of Affliction that turned out to just be a boring combo-spender with all flavor gone and dots that tickle. Destro is also psudo wrath destro gated behind needing haste so they suck 2/3 of the expansion till the end. Demo started 17 dps ranks below BFA demo and they have cried non-stop until blizz just buffed them to the moon. Locks also the worst at pvp now thanks to other classes being buffed, and our flavor spells have been replaced by toys/potions/food other players bring.
Are there improvements? Yes… and I’ll give Blizz credit for surprisingly faster improvements than usual too. That’s how dire of a situation locks were/kinda still are in when being sat 100% for any M+ and passed in raids/pvp for classes with better burst/movement.
In conclusion the OP’s correct in that there’s still no reason locks are needed in WoW anymore other than they fit the lore. All the mystery is gone. The favored classes are zoomers (mage and druid) and warlocks are the boomers.
In all honesty this lock is not my main because of how they are in SL… Other than issues the OP mentions, they are just plain boring. Blizz refuses to add any sort of customization to them, the demons are old and boring. Green fire is old and boring…
You’re one of the rare breeds then man. We do not enjoy the spec it is not fun it is very good damage but so bad at doing everything that it doesn’t make up for the damage