Warlock is not good, and the changes they made over the expansion, especially after aberrus have been very disappointing so i will make a list of what i think they should do:
Warlock:
1: Revert the awful change done to grand warlock design, static cdr… Might as well just make it baseline then, if it’s just a static cd decrease there really isn’t a point in this being a talent, bring back cdr on soul shard spend, especially important for destro
2: Gwd in the class tree
3: main demon cds summons baseline
Destro:
1: channel demonfire should generate 1 soul shard fragment per bolt, and be castable while moving
2: remove pyrogenics, put cataclysm in it’s place.
3: Change crashing chaos. The damage buff is boring, make it like this instead, when you have infernal up and you use rain of fire or chaos bolt, it makes you next rain of fire or chaos bolt deal 30% more damage, and have it’s cost reduced by one soul shard.
4: Bring back madness, with a longer duration, chaosbringer is TRASH.
5: soul fire insta cast, immolate ticks have a chance to reset it’s cd, chance is reduced the more enemies you have immolate on, so you don’t just get procs 24/7, this is something they already do anyway for things like agony.
Demonology:
1: revert all the awful changes done after aberrus, the 3rd dog removal, the reduced demonic core procs etc… All of it, reverted, those were awful changes and should have never seen the light of day.
2: portal changed to a more sustain profile, if gwd is in the class tree, the changes are reverted and you can take tyranny, that’s enough burst already, no need to increase it even further since it’s gonna get nerfed anyway.
3: Hand of doom is better than doom. No one is gonna use that talent as it is.
4: Pact of the imp mother should work as if you spend double the resources, so it should interact with talents that scale off soul shard consumption, and things like dread calling.
5: bring back the vault tier set as a talent. Instant hand of doom is quite cool.
6: tyrant should generate 1 soul shard at the start, then 1 every 2 seconds, and one when it’s over, instead of just being 5 at the start.
Affliction:
1: Bring back the shadowlands tier set.
2: Dread touch and doom blossom are too polarized.
3: haunt should be integrated into unstable affliction, haunt is currently the de facto example of a bloat ability.
4: soul flame removed and seed buffed to compensate
5: Darkglare should have a soul shard generation component.
6: remove siphon life
And that’s about all i can think of. When everything is done simply rebalance.
The list is quite long as warlock is frankly quite awful and has been getting progressively worse over the course of the expansion.