And we have see the common folk of Stormwind rise up constantly because their very army was no where in sight in Vanilla. We saw say Darkshire or Westfall, heck we even see Lakeshire learn to fight because their lands happen to in fairly bad shapes.(as a quick example we see Lakeshire trying to fight off the Scourge in Shadowlands, I am relatively certain they managed to beat them back)
You mean:
All who could walk were pressed into service. Even those generally regarded as civilians—tailors, food merchants, innkeepers—had learned over centuries how to fight well enough to defend themselves.
Compared to say:
Roused by the tales of the orcs’ atrocities during the Second War, the peasants have
learned to use both pick and axe to defend their communities if threatened.
Both community were threatened by external forces. Both civilians in said races have learned to actually fight to defend themselves but like we see they are not master warriors. At best defend themselves in the same way most militias are actually able to do , but not much more then that and certainly not stop an actual well trained army on their own.
I am not sure this is an honest interpretation. We know Tyrande made a profession army of Sentinels. We know not all of the night elves were druids or part of the Sentinel army. So I do think there was a “civilian” population even during the Long Vigil. On that note:
All who could walk were pressed into service. Even those generally regarded as civilians—tailors, food merchants, innkeepers—had learned over centuries how to fight well enough to defend themselves
It seems to me these tailors, food merchants, innkeepers etc have been doing their jobs long before Warcraft proper. That they did train to fight but never joined the night elf military proper.
Again, this rings false, the same boast is also present in Stormwind, that most men(and I assume now women) actually learn how to use a sword at a young age. Stormwind was probably the second most militant(apart from say Stromgarde) human nation due to the fact it was a relatively isolated kingdom with dangers all around it.
We literally see Goldshire, Lakeshire, Sentinel Hill and Darkshire try to deal with their problems on their own for most of Vanilla precisely because the Stormwind army was not around.