Veterancy Level 0 does not apply attributes

Hi there,

Thank you for your hard work with this patch.
One of my maps heavily relies on old hero&inventory systems and I’m testing it against the PTR patch to find any inconsistencies.

My veterancy uses the old system and it’s rather straight forward.
For example, one hero gains 2 points to his Stamina and 2 points to his Strength each level. It also means that he should start with 2 points for each attribute.
This is how it behaved previously.

However, now, he starts with 0 points in each attribute and during the first level up he gains 4 points of Stamina and 4 points of Strength. Level 0 is described with MinVeterancyXP=0 but that seems to be omitted in the XML. Adding it manually in the XML doesn’t fix the problem.

<CBehaviorVeterancy id="HeroVeterancyFootman">
    <EditorCategories value="Race:Human,AbilityorEffectType:Units"/>
    <Flags index="CombineXP" value="0"/>
    <XPFraction index="Kills" value="0"/>
    <VeterancyLevelArray LevelGainEffect="GlobalLevelUpSet">
        <Modification>
            <AttributeChangeArray Attribute="HeroStaminaFootman" Points="2"/>
            <AttributeChangeArray Attribute="HeroStrengthFootman" Points="2"/>
            <AttributeChangeArray Attribute="HeroAgilityFootman"/>
            <AttributeChangeArray Attribute="HeroIntellectFootman"/>
        </Modification>
    </VeterancyLevelArray>
    <VeterancyLevelArray MinVeterancyXP="400" LevelGainEffect="GlobalLevelUpSet">
        <Modification>
            <AttributeChangeArray Attribute="HeroStaminaFootman" Points="2"/>
            <AttributeChangeArray Attribute="HeroStrengthFootman" Points="2"/>
            <AttributeChangeArray Attribute="HeroAgilityFootman"/>
            <AttributeChangeArray Attribute="HeroIntellectFootman"/>
        </Modification>
    </VeterancyLevelArray>
    <VeterancyLevelArray MinVeterancyXP="1000" LevelGainEffect="GlobalLevelUpSet">`

This can of course be easily fixed by giving a permanent behavior that increases the attributes from the start and removing the Level 0 increase of attributes but it is inconsistent with previous behavior thus I decided to post it here. Hope you don’t mind.

Regards
Matic