Hello. I'm really new to wow lua and addon coding. There's an addon called who pulled that was nice to have in case of griefers. The addon hasn't worked for a while now because of changes to the api and lua in bfa and possibly legion and I decided to try fixing it.
I have already managed to fix/repair the main function of the addon, which is actually noticing that someone pulled something, I'm also not 100% sure that my fix is completely valid.
I changed
if(IsInInstance()) then
time,event,hidecaster,sguid,sname,sflags,sraidflags,dguid,dname,dflags,draidflags,arg1,arg2,arg3 = select(1, ...);
to
if(IsInInstance()) then
time,event,hidecaster,sguid,sname,sflags,sraidflags,dguid,dname,dflags,draidflags,arg1,arg2,arg3 = select(1, CombatLogGetCurrentEventInfo());
I'm having trouble finding why it won't print it as a private message to me automatically when someone pulls, it used to do this whenever someone pulled something, but now only works with the commands /mwho /ywho ect.
Here are links to the current modified file of the addon and the addon itself.
https://pastebin.com/PqxC0ThQ LUA
https://wow.curseforge.com/projects/whopulled Addon
Both Exorsus Raid Tools and Details! can tell you who pulled a boss.
It appears from the code you posted that unless you have Automatic Yell turned on (which sounds obnoxious as hell) that it wont display who pulled automatically. You can /mwho to output it to yourself on a case by case basis.
1 Like
There is not one single print() command in the code you posted. Every slash command not configuration related is using the WhoPulled_SendMsg() function that passes informatio0n to DEFAULT_CHAT_FRAME:AddMessage() or SendMessage().
Your qquestion is half formed,
What do you want to print and where? A seperate slash command to just use print bypassing the chat frame? Print as well as chat? Something completely different?
It used to always do a private message to my main chat window, automatically, just like DEFAULT_CHAT_FRAME:AddMessage(This is message); would do, when someone pulled, back when it worked.
And I know about details and exorsus but they only track boss pulls and not someone pulling adds on purpose, zul for example. Also bade on my experience with details, it seems pretty hit or miss for actually noticing who pulled and half the time it just says ???
The code should have the function to just print it to you privately in the main chat window
It seems something like that could be included after:
if (not WhoPulled_Settings["silent"]) then
I've been fiddling around with the code around there and have not made any progress. It also seems to be stuck on yell when boss is pulled and will not let me change it from the visual settings
I've been fiddling around with the code around there and have not made any progress.
Both Exorsus Raid Tools and Details! can tell you who pulled a boss.
https://www.curseforge.com/wow/addons/exorsus-raid-tools
https://www.curseforge.com/wow/addons/details
Seems to be working now, the settings had just broken from the ui version somehow, configuring it with the /wp commands made it work. So all that needs to be done is the CombatLogGetCurrentEventInfo() afaik.
Seems to be working now, the settings had just broken from the ui version somehow, configuring it with the /wp commands made it work. So all that needs to be done is the CombatLogGetCurrentEventInfo() afaik.
Hi Paladinne. I was hoping someone would fix this old addon I used to use as well. I thought that by default it /y the target who pulled. I seem to remember seeing it fire a lot in LFR's back when it worked. I think there was a way to set the way you reported it.
Have you got it all working again? If so I'd very much like to get ahold of the working files.
Both Exorsus Raid Tools and Details! can tell you who pulled a boss.
Thanks for the tip about ERT. I'm going to check that one out.
I just downloaded Details! and I'm having trouble locating the who pulled section. Can you give me a Dummies heads up on where this is please?
I just downloaded Details! and I'm having trouble locating the who pulled section. Can you give me a Dummies heads up on where this is please?
Honestly not sure where the options for it are. It's enabled by default and pops up in your chat whenever someone pulls a raid boss.
[added]
Found it. Options > Raid Tools > First Hit (bottom right)
Keep in mind it wont be accurate for things like body pulls, that's where ExRT comes in.
1 Like
Honestly not sure where the options for it are. It's enabled by default and pops up in your chat whenever someone pulls a raid boss.
[added]
Found it. Options > Raid Tools > First Hit (bottom right)
Keep in mind it wont be accurate for things like body pulls, that's where ExRT comes in.
Great, Thanks Elvenbane :)