Well, there’s a few things to consider really.
Are you going for RP or Aesthetics, or are you trying to min-max.
One could make arguments for really any of the racials being useful in different situations (even the bad ones) but there are some special ones to consider.
As you noted Orc is generally the go to for PVP.
Rocket Jump IS great for preventing fall damage, but Warrior can also do this with Heroic Leap (Jump down to the ground while you’re falling, easier than it sounds unless your latency sucks) Though there’s generally 1 or 2 mechanics goblins can cheese with this per expansion.
Things like Vulpera extra inventory are really useful, even if their existence is an abomination, and they are probably the best for casual content with that and their teleport.
Aesthetically it’s really up to you what you do.
If you want to stand out more I think Goblin is one of the least played races hordeside.
Forsaken fury warrior. There is nothing more terrifying than an undead berserker swinging 2 six foot blades or 2 huge axes that you can’t keep feared. Think about it, do you really want that coming after you?
personally i would go either orc/maghar, zandalari, or blood elf. their racials are decent and they all look good in plate armor. (the necrolord plate set boots cover troll feet if that’s a concern for you). plus, their animations are all very good. goblins and vulpera are both serviceable if you want to play a tiny race though
First i was like lessss gooo big boof orcz! But yeah charging at someone with a teeny lil gobbo is fun too (fun with gnomes as well). These are the real questions.
I third the motion, despite the OP not considering Pandaren for the warrior class. (Of the original two options given, I vote Tauren; I’m biased, since I’ve a Tauren warrior but not a Goblin.)