Seems like tauren make the better tanks and orc makes the better dps.
Is the difference big enough that if i ended up playing dps in a raid group on my tauren warrior that i would be regretting not going orc? Or on the flip side if im playing orc and end up tanking alot will i be gimped compared to a tauren?
These are the only two horde races that appeal to me aesthetically for warrior is why they are my only to choices.
if PVP style, ORC! But if you like picking up the daisies and like stompin around cow
orcs hands down, that axe spec + stun resist is too good
Unless you’re minmaxing, what race you play doesn’t really matter.
That said, orcs and taurens are both equally great tanks for different reasons. The stun resist can be really clutch sometimes, and Taurens being able to take a beating can really help out healers.
But you should play what you want to play and not worry about racials. Racials matter in Classic, but they aren’t pivotal. 
Will of the forsaken boom
Idk charge + stun + increased health+ increased melee range is very very good in PVP.
but so is 25% stun resistance and increased Axe weapon skill and also blood frenzy ( i think that’s what it was called)
I dont think you can go wrong with either race.
Been torn on playing priest or warrior, but if I do choose warrior, personally going orc for sure. They just look right to me.
It’s down to what you think both looks better, and since you want the terms of racials, Orcs get a 25% chance to resist stun effects. That one lucky resist could make or break a fight in PVP scenarios. Tauren do get War Stomp though, which is a nice quick “Get off me already” button and a little extra stamina. It’s not a TON, but every little helps and there’s no real wrong answer.
TL;DR Play whatever you like.
if pvp orc
if pve tauren