The letter to Genn says Calia is removing all forsaken from Gilneas, hinting its gonna become an alliance city again. Well this conflicts with Legion lore. Anyone who played the Legion rogue campaign will have visited Gilneas when told to assassinate the leader of some random group of bad guys - ALL human with guard dogs. No forsaken to be seen anywhere, but the evil group infested the city, which they likely left after you killed their leader(and assumingly, some of them).
That would either mean they[forsaken] got pushed out of the city temporarily and came back or they left and Calia thinks there are forsaken there to begin with.
I’m pretty sure that you’re describing the Fangs of the Father questline from Cataclysm here. During the time of that questline, Gilneas City was reclaimed by a group of Gilneans secretly being led by a Black Drakonid IIRC.
Rogues did get a questline in Legion about assassinating demons disguised as citizens in the major capital cities, but that didn’t involve Gilneas.
There are inconsistencies in the lore regarding Gilneas during BfA, however. The mission table makes reference to Gilneas being back in control of the Gilneans. There may have even been some foreshadowing to Gilneas returning to Gilnean hands in Legion and there was a BfA trailer implied that the Alliance would control Gilneas.
In fact, they outright stated at a Blizzcon event that the Arathi Warfront was partially being fought over Gilneas, a lore aspect that never made it into the game itself (Gilneas is never actually mentioned in relation to the Arathi Warfront).
There was definitely an idea for Worgen to have control of Gilneas during BfA, but it was presumably canned by Alex Afrasiabi or something.
Confusingly, Gilneas has also been mentioned as being fully abandoned and in complete ruin, too.
Maybe it’s possible that the Forsaken won control over Gilneas during BfA, thus meaning that the BfA mission table could be canon to an extent after all.
I don’t know that the Forsaken ever occupied the city though. They were really on the coasts with small contingents in certain areas but I don’t recall them ever occupying the city itself. Perhaps at one point in Cata but many of the Forsaken troops were pulled out due to the Legion invasion.
So really Calia is just recalling the scraps of an occupation force. I think the Gilneans just didn’t have a big enough force to fight the full army of the Forsaken if they did try to retake their country. But now they don’t have that worry anymore and the land is just being left empty for them to reclaim without any military fighting.
If Worgen get Gilneas back then Goblins should have had Kezan returned to them too. Afterall Undermine might be the most amazing city in all of Azeroth.
lol in all honesty if you think about how the story went if they followed how the characters actually acted which they didnt, there would be no horde civil war there would not be outrage at derek proudmoore becomming undead as most of the horde knew thats where the new forsaken were comming from. it was painful how out of character the devs made the characters, id love it if what stopped the war was n’zoth invading forcing us to work together and end the war like they did in the past. its just frustrating.