how is a prot warrior at soloing stuff … questing … rares … and doing visions ?
i have played fury warrior and loved it but really wanted to try something diffrent and was really leaning towards prot warrior … how are they in pvp ? any good ?
thank you for any advice in advance 
Prot warriors are completely fine in all of the pve stuff you listed. You won’t have any troubles whatsoever. As for pvp, no tank is good. You can currently abuse some corruptions for hilarity, but that will soon be gone. You’re far better off playing one of the dps specs for pvp other than memes.
I find fury to be better for all the solo stuff. It’s way faster, and though you take more damage, you also have impressive self healing.