I’m looking to find out if there is a general guide that tells you what Profession id good for each class or Race.
have you tried Google?
Engineering is the answer for all.
For the most part this is accurate.
There’s a few other considerations though… mostly revolving around your access to crafters and willingness to make an alt army. If you’re playing on a small realm though, herbalism is absolutely essential. Those communities are relatively friendly so someone can always craft what you need, but being able to gather the mats yourself are pretty critical.
I’ve lived my WoW life without having Engineering on any of the characters I play, but it certainly comes with an amount of regurtz whenever I PvP 
Race doesn’t matter at all.
Class only matters if you want to wear armor that you made yourself. Most crafted armor is not bind-on-pickup, though, so again it doesn’t matter much because you could just buy the crafted piece.
Other than that, you might want to match crafting and gathering professions, i.e. blacksmith/miner, leatherworker/skinner, etc.
What are you trying to do? Make money? PvP? PvE?
1 Like
Depends on what you want from the professions and how much work you are willing to put into it.
Mining/Engineering and Herbalism/Alchemy are good safe defaults for many classes.
Basically it’s a safe bet to use Engineering/X.
All depends if you want to be self-sufficient, have multiple characters you can spread the professions across etc. On my rogue I’m lazy and go mining/engineering. My main alt I go herb/alch. Then I have a lowbie alt that has enchanting mainly to DE and fund my two main characters enchant materials.