I’m starting a new Priest for Shadowlands and was wondering which professions to level. I enjoy having professions that are useful in gameplay, but gold making is also a plus, obviously. I am fairly casual, but do both PVE and PVP content.
I have a Mage with Tailoring and Enchanting already. I’m not sure if I’ll level that character in SL, but I suspect I may do so if only to take advantage of those professions. So, those two are not likely options for the Priest.
Thanks!
Herbalism and mining early in the expansion for big gold.
Herb/Alchemy and Herb/Inscrip for next big gold if you want to use your own stuff.
Tailoring next since profession gear actually isnt supposed to be bad although I don’t know if you need to actually have the profession to use the good stuff.
I always like Herb/Alchemy. Good way to passively make a reasonable amount of gold just by spending time out in the world, and it’s always nice to have potions/flasks.
I can’t do without engineering for the nitro boost 
Engineering gives you a Brezz which is pretty useful for M+.
But I like Alchemy/Herb the Trinket in BFA was pretty nuts and having flasks is something really useful for progression. There are also some utility potions like one that gives you a boost of movement speed for some seconds that saved my life in many situations.
I favor skinning as I don’t have to go out of my way to do the profession. It’s fluid, as I kill stuff, I skin. I’m able to sell all the mats for decent gold on the AH. I stick with tailoring because I like making my own bags.
Herb/Alchemy is good for bringing your own consumables. If you want to do M+ then you can do Engineering/gather profession.
I did hear they brought back the combat res and drums. Just prepare for ridiculously priced goods until flying is implemented so it’s better to gather your own stuff.