PVE… you have several options, all good options.
PVP… engineering + whatever helps engineering.
Just try both, see what you like. It can be pretty fun to make your own gear with tailoring. And it can also be fun to make potions. Just literally see what you like, you can’t go wrong here. It’s only wrong if you don’t actually enjoy it lol.
If it helps… just think if you like farming flowers. If you don’t than tailoring is easier, since you get ton of cloth as you level. For flowers you have to go out of the way most of the time.
I prefer alchemy over engineering if I’m ranking in PvP as a disc priest. Of course both would be great if you were rich and had all the time in the world, but if you have to choose one I’d go alchemy. If i’m shadow, or just memeing around in the world, I’d go engineering. I say that because alchemy grants a ton of utility without sacrificing valuable gear slots. PvP gear for priests makes a huge difference because of how weak we are. Rocket helm and speed boots takes up to almost a thousand health from you in comparison to PvP gear, and as a healer reflectors and nets take up another valuable trinket slot or two.
Edit: OP I’ll be going tailoring/enchanting while leveling, switching to herb/alch once I craft truefaith vestments and get a mount for herb farming.
I would say Enchanting/Tailoring or Mining/Engineering.
New meta for PvE has engineering as a staple… though not everyone does this.
Enchanting is the most profitable profession in the game, especially if you are able to be the guild enchanter… may not be worth it if you are not.
All gold farmers are enchanters…just even for the dischant option.
If you are REALLY hardcore/ good at farming… Engineering/Alchemy or Engineering/Enchanting or Tailoring…
but that’s pretty brutal.