I know there was a lot of push back on explusom in BFA and Uncanny gear being lock behind PVP’s Marks of Honor. However, it make professions worth investing in. Every profession except skinning on my server isn’t worth it or its in the red.
This is due to the fact that everyone can easily leveled up professions and craft every recipe.
The investment is now in grinding out the lower ranks of the legendary base items. None of the rest of the items are really even worth talking about. Crafters can make 7 levels behind normal 5-man gear, or 3 levels behind heroic 5-man gear after grinding for a month in the Maw.
Problem with the base items, of course, is that everyone needs to grind them out to get to the higher levels, and the supply way out-paces the demand, especially since alts are heavily blocked from legendaries by needing to grind (and step up through the wings) Ash separately and without catch-up.
Crafting any item is not always profitable, but I would be willing to bet that certain crafts for any profession can be profitable. For enchanting for example I can make money but only off a select number of enchants. Usually Tenets and weapon enchants. For cooking Gluttinous Feasts and 1 or 2 single-use foods. Not all recipes are profitable since as you said it is not very hard to get into professions.
Engineering would beg to differ, but for everything else, yes, that’s probably true.
gliders say hello 
they always sell. but i understand your point. Engineering was made to be useful and also for pvp and less about making gold.
Rarely more than their high-priced mats, since they are from like 3 expansions ago. So unless you just adore farming WoD zones for fur and ore, they don’t sell for much profit at all.
They do ok on my server but yes there isnt much profit