Can see in the combat log that both the two last hits glanced, and the proc is on full duration. So it can indeed proc on glancing blows
That leaves spellhit to be tested
Im trying to think of anything else that might have caused the 1ppm data earlier but Im really lost for ideas. Even if the proc for some weird reason was subject to spellhit it should not have its procrate lowered by 50%
Little sidenote about the findings - i didnt account for the hunters auto attacks. So with 112 possible attacks that landed and dealt damage including blocked and glancing (wc+autoattack+raptor strike) 13 of those had a proc. 8.61% proc rate (112/13)
If it was listed in vanilla with a 2ppm
(60 (seconds) /3.5 (base weapon speed) ) = 17.14 (swings in a min)
2/17.14 = .1166 or 11.66%
Is my math correct that its actually correct or very close to being correct if the proc is based on the swing and not landed?
EDIT - didnt take into account all misses/dodges - of 133 casts 112 landed. Updated math.
Yes, nightfall isnt broken. It’s just the fact you aren’t accounting all the factors when doing the math. You have to remember that without every single piece of relevant information your answer will be skewed. All the logs posted are in line with the proc rate when you take into account all the data.
Ian on the Paladin theory crafting discord is compiling logs with NF uptime for comparison:
IanToday at 7:48 AM
Based on the data we have available, you should assume an ~8% proc chance in raids right now. We don’t know where the missing 3% is going compared to open world tests in Blasted Lands (~11%) Keep PMing or linking logs here so we can keep compiling data.
@GoatTribal (Azial-Kurinnaxx) were there more people with NF?
GoatTribal (Azial-Kurinnaxx)Yesterday at 9:36 PM
I was the only NF user
Luciron: 0% uptime
Mag: 0% uptime
Ghennas: 0% Uptime
Garr: 0% Uptime
Baron: 4.1% uptime (1 proc)
Shazz: 8.38% uptime (2 procs)
Sulfuron: 7.46% uptime (1 proc)
Golemagg: 19.08% Uptime (3 procs)
Majordomo: 3.4% uptime (2 procs)
Rag: 9.69% uptime (2 procs)
Crea - AtieshYesterday at 10:21 PM
this is a very rudimentary analysis, but in effect, it’s looking at Nightfall proc chance when the bosses have Deep Wound up, which is an indicator that there are not 16 other high priority debuffs on the target. Sample size is still small, but after 13 logs, only one saw a reduction in proc chance (and that’s in MC where some bosses are deep wound immune and can skew the data significantly), and overall proc chance increases. This would seem to support the idea that it’s being blocked from proccing on bosses with a full set of debuffs.
It helps to explain why some people would see consistently low proc chances, as the common factor across their parses would be their raid and how they handle debuffs. The hypothesis being if your guild manages debuffs closely you’ll see higher proc %. Currently seems plausible. Will continue looking at this.
I can confirm that Judgement of Command can proc Nightfall. The issue with Pally uptime seems to be that Seal of Righteousness is not proccing item effects like it should. The patch-notes support this. And I am not sure how it is interacting with Seal of the Crusader attack speed either, whether or not the buff being up on hit or at all during a swing-timer effects the proc chance.
face meet palm…i think I know why the proc rate is so abysmal against raid bosses…
THEY’RE USING THE TBC VERSION OF NIGHTFALL WHICH HAS MUCH LOWER PROC RATE FOR EACH LEVEL ABOVE 60!!!
TLDR - Nightfall’s proc rate was nerfed to the ground during TBC cuz Ret Paladins and Prot Warriors were using them on Brutallus to help nuke him down:
[Nightfall] now has a chance to fail on targets over level 60. https://wowwiki.fandom.com/wiki/Patch_2.4.2
By Klarno (2,946 – 1·5·20) on 2008/05/01 (Patch 2.4.1) A test on the PTR has shown that this weapon has <0.1% proc rate at lvl 70.
By Blightstar (4,647 – 1·7·21) on 2008/04/23 (Patch 2.4.1) Patch 2.4.2: Nightfall now has a chance to fail for targets above level 60. No idea how big the chance is but i think it will nerf the use of this weapon completely. Sad thing really …
By skron (1,343 – 3·14) on 2008/04/07 (Patch 2.4.1)
*This may have renewed life on Brutallus… *
Whichever protection warrior is not currently tanking can equip this and whack away, increasing your caster dps on the fight where it’s needed most. Swap as needed.
Haven’t tried this out in a raid setting yet, but should in the coming week. https://web.archive.org/web/20160224122420/http://www.wowhead.com/item=19169/nightfall#comments
Elitist Jerks thread about Nightfall during TBC and the nerf to it: https://web.archive.org/web/20080430023845/http://elitistjerks.com/f31/t17089-paladin_protection_you/p55/
I got curious and looked at two of our logs from last Friday’s MC, where one of our Tanks was using Nightfall on some fights. We have 2PPM, or higher, on two of our fights. I haven’t checked the rest (he wasn’t always using the Axe). We’re Alliance, so no Windfury Totem here.
for comparison - here’s TBC and onwards version of Crusader enchant https://web.archive.org/web/20160302213050/http://www.wowhead.com/item=16252/formula-enchant-weapon-crusader#comments
Teaches you how to permanently enchant a melee weapon to often heal for 75 to 125 and increase Strength by 100 for 15 sec. when attacking in melee. Has a reduced effect for players above level 60. Cannot be applied to items higher than level 600.
The “easiest” way to confirm if items are in fact using TBC values is to use Tidal Charm on level 61+ targets and document the resistances versus level 60 targets. You will need hundreds of hits though to verify any data.
Or maybe there is a different item that could be used to test the TBC theory.