So, I’ve completed this achievement a long time ago on the alliance side and many forums say that I don’t need to re do the entire Suramar quest line again to get it again.
I’m trying to unlock the night borne race.
When I go to the embassy in org and check the banner, it shows that I need Insurrection still, but I’ve done it on my old alliance character.
All research points to only needing this achievement done once.
Have you logged into the character you got the achievement on recently? If you got it before they added in the Allied Race quests, you may need to make sure the game has seen the achievement progress, which logging into the original character should do.