BE Assassin, because I am awesome and it is super fun 
Just do a class trial with each race/sex and see what you prefer. Iâm not a fan of NE or VE male rogue animations myself. So just see for yourself. Sin is the better of the two specs right now. Not many people are playing sub but if your just doing solo play I doesnât matter. Just play what you enjoy the most.
Night Elf primarily for the Shadowmeld bonus
Honestly, if you have full heirlooms you arenât dying in the open world at all until at least 100+. If you put elemental force on your daggers youâd be pretty much unstoppable while leveling. Cheat death would more come in handy to survive in a dungeon or something.
You mention youâre into the lore for night elves so Iâll assume you have at least a passing interest in immersing yourself into your character and base my reply off that.
With night elves, you can imagine yourself as a sentinel, warden, or part of another martial order with a rich and ancient history. Youâd be more of a scout/special agent type who mastered stealth than a wielder of shadow magics. This is the more âphysicalâ option over void elves, whereas the void elves better represent the magical aspects of shadow that you utilize as a rogue. Whether you want to RP yourself as a trained sentinel or a shadow-infused assassin, I think youâll love either choice. Thereâs a lot to work with 
I would make both. A Night Elf Assassination Rogue because poisons are nature. And a Void Elf Subtlety Rogue because Subs use Shadow Magic.
If I could do a Rogue that is affected but the Emerald Nightmare that would be so epic, but alas, I have yellow and black eyes to pick from. Neither color I care for lol. But I am sure there is good mogs
There are AMAZING Legion mogs, get the shoulders from Xavius and do your Nightmare RP, friendo. It looks sick.
OHHH! I see a Doomblade set. But it is Mythic Legion Nighthold 
That gonna be a b**** to get I can imagine
Not as hard as you think, you get a 20% chance for a drop on every boss, true, but if you bring a lot of leather classes to a NH run (and a lot of people still run this for xmogs) you can trade pieces they may already have.
Loot sharing is like 90% of my Legion xmog collection lol
Neither and neither.
Pandaren outlaw. (I know you wonât, but Iâm honestly trying to help.)
Assassin, and void elf for a bit of extra damage.
Shadowmeld is nice but not necessary for a rogue.
Yeah, I am not trying to be mean to you at all in anyway, but I hate Pandaren and would never roll one. I have two races I refuse to play, Gnome and Pandaren lol.
Why not switch between assas and subtlety? See which one you like best? I like assassination myself. Mutilate is cool.
Ohhh, very nice! My bigger concern is getting a team for a Mythic Legion Raid, I am not to big on raiding, more so a quest / dungeon guy. But I would be happy to give it a try for the transmog gear
TbhâŠit depends on the player rather than the stats in a lot of cases. Each person may look at some things as beneficial over others but it can be put down in the depends on player section again. PvE: A rogue, no matter what race or sub class, can be very good. PvP: This is where a player will define how each one plays. Youâre not just stabbing at an npc mob who has defined movements and attacks/defends. So knowing how to react becomes more important (slightly) over who has the better racials or who has shadowmeld. Rolled a Void Elf Rogue and am absolutely loving it. Pure Assassin and am able to handle PvE really well (and against multiple mobs) and still am able to use vanish to get out of tough situations. Having shadowmeld would be nice as an extra escape method but the only times I have ever could have used it was putting myself into a dumb and desperate fight against more mobs than I could handle.
That is very insightful, thank you for the response! I think you are right, I am gonna go Void Elf Rogue and I will make my Warrior a Night Elf
Going a melee class as void elf means you forfeit your super OP passive that only benefits casters. Melee classes just suck if you are void a elf.
The official rogue Discord is your friend. Google for it and use it wisely.
No, I do not use Discord and do not want to. Thank you, but I will stick to the Forums for enjoyment and Google, I asked here for more fun than seriousness⊠lol