I think affliction is fine, but nothing special.
Too many 2 talent nodes, the majority of the capstones are boring.
I would recommend putting vile taint on 20 seconds, I don’t particularly like haunt, bit it’s kinda whatever, would be nice if it did something, a little extra to make it a bit more interesting, like proc nightfall, or give you a soul shard.
I would like to see the shadow bolt volley have a chance to proc crescendo. And maybe make it uncapped, it would be so awesome to see a massive 10 target volley or something like that.
The soul rot capstones are cool, but they last too little, I think it’s called dark harvest, make it last for as long as soul rot is on target. This would also give some excellent interactions between darkglare and soul rot.
Maybe though… Take a page out of splintering elements from shaman and make it so you get big value out of the main target and each subsequent target gives you less stats than the main one. Right now you have 4% up to 5 targets.
Make it 10% for main target, and each new target gives you 2% extra, but up to 6 target cap, not 5.
The dot extension instead is nice, nothing to say about that really aside maybe it’s a little weak, and I think I would prefer if it worked like the shadowlands tier set, obviously they would have to put a cap on how much soul rot could be extended, especially if they change dark harvest to what I suggested
The hero talents for warlock are high quality though, i especially like diabolist and harvester, I think hellcaller falls a little flat, especially for affliction, not the biggest fan, and it was cooler when you could make wither tick like crazy, especially for destro.
Talking about destro, i did not enjoy how ritual was handled for it, they should have assigned different CDR based on the spell you casted, shadowburn 1 second, chaos 2 seconds, rain of fire a fraction of a second for each target hit each time it hits with a target cap of 5 or 6.
Also did not enjoy how decimation was nerfed, or how they nerfed ritual of ruin and infernal. I also liked grand warlock design a lot, but that probably not gonna come back at this point, still an awesome talent though, especially for destro where the CDR for infernal in AOE scenarios could get pretty insane, for demo and affliction I don’t miss it as much
But overall destro is solid gameplay