It’s all about tradeoffs and whether you find those tradeoffs are a good fit for you, and if you like the general “theme” of the spec.
We have decent, but not amazing, burst. The tradeoff is that we actually do decent damage outside of cooldowns as well. For me, I like being able to deal damage more than 15-20 seconds every 2 or 3 minutes and then feeling like doggy doo every second in between. This is what really turns me off from, say, fire mage.
Spriest’s immobility is real, but a bit overexaggerated, and the workarounds aren’t readily apparent if you’re not too familiar with the spec. You’re right, we do not have great burst mobility, like mage blink or warlock gates (which require optimal positioning and a bit of luck), but we do have short mobility increases with Body and Soul on a near-zero cooldown. At least it’s not like Burning Rush, which deals 4% hp every tick. We also have numerous instant-cast abilities that allow us to stutter-step frequently. Learning when to pre-position well ahead of mechanics is key as shadow, so the more you prioritize a proactive mindset about positioning rather than a reactive mindset with burst mobility the better off you’ll be and the less you’ll feel mobility is an issue.
Protip: choose the Void Elf master race so you have a ghetto blink every 3 minutes to get around bad mechanics like Eye of the Jailer’s insta-kill beam.
As for buttons that don’t have synergy, I think we have something like that with every class. Or worse, a situation where over half of your talents that don’t have much application anywhere. About 75-80% of shadow talents find a use somewhere, whether in PVP, M+, or raiding. I really feel this when I switch over to mage, where it seems like half the talents are dead talents that you just never pick in any scenario.
The rotation in VF just takes some getting used to. After the first few casts it’s really just about spell priorities. It feels hectic at first, but trust me it’s nowhere near as hectic as it was in Legion with high voidform stacks. But some people don’t see it as hectic per se, and really just see it as fast-paced.
I agree the shield looks meh. A shadowy glyph to make it more purply would be much appreciated. I will tell you, though, that in terms of visuals priest has S-tier transmog. And again, if you are void elf master race you get a huge transmog discount, so it never feels like your bank is getting gut-punched while you try out all the cool armor sets.
Also regarding visuals: I really like the shadowy apparitions.
I think Devouring Plague was a bit over-nerfed, and yes it could feel better to press.
I agree shadow’s AOE is terrible. It’s clunky and requires too much of a GCD investment to do anything passing as decent. AOE is not their strength, though, which is single-target (especially with bosses in the execute range).
Here are some other things shadow really brings to the table in my perspective:
Excellent self-healing. To me, this is a major thing. I really dislike having to rely on a healer being competent to save me when my health starts getting low. I like being able to take care of myself sometimes if I need to. Also, shadow has excellent passive self-healing which helps offset the mobility issues somewhat.
I really like the dot playstyle. Especially the “dot and trot” playstyle in open world. Take druid for example. Yes, you hit for more with starsurges, but the druid dots are so meh.
I really like the whole void theme and the theme of messing with people’s heads. And I don’t really like pet classes (shadowfiend notwithstanding). If you like pets then of course me valuing non-pet classes won’t be relevant.
Shadow Word: Death in open world is also very satisfying and convenient to use.
So let’s say none of these qualitative statements sound appealing. Very well. Let’s look at the numbers.
Mythic raiding: https://www.warcraftlogs.com/zone/statistics/28
In terms of all dps, shadow priest is the 6th most popular spec. This is especially relevant when you consider that most raids already have a disc priest - shadow is still finding a spot even when the raid already has the priest class buffs. Shadow is a more popular choice than any rogue, warlock, shaman, or DK DPS spec - and that’s saying a lot in shadow’s favor!
It looks even better when you get to Heroic raiding: https://www.warcraftlogs.com/zone/statistics/28#difficulty=4
Shadow is the 4th most popular raiding dps spec.
Lots of people are finding it fun! But in the end, it’s all about if you find the tradeoffs and the spec’s theme to be a good fit for you. Only you can decide!
Cheers.