Broken Macro

Guides UI and Macro
1

Hi all-

I’ve been using the following macro for DPS as a holy priest for many years now. As of the pre-patch, it seems to be broken. I’ve been hunting around the forums, and it looks like there’s something to do with button presses being broken? I don’t know if that applies to just addons or to macros or both. So I figured I’d post here and see what y’all thought.

This is what I use:

#showtooltip Holy Fire
/cast [mod,@target,harm,exists][mod,@focustarget,harm][mod,@focus,harm][mod,@targettarget,harm] Holy Fire
/cast [nomod,@target,harm,exists][nomod,@focustarget,harm][nomod,@focus,harm][nomod,@targettarget,harm] Smite

I have that macro on a button bound to shift+3. Pressing shift+3 on my keyboard has always successfully fired Smite, and shift+clicking on the button itself has always successfully fired Holy Fire. Now, the macro only fires Holy Fire no matter what or how I press/click/activate it. I hope this makes sense. I am a creature of habit and have been using this combination for many, many years now–and in some form on all of my healers.

Thank y’all for any advice you can provide!

2

The UI and Macro forum might be a better place to troubleshoot.

3

Thanks! I’m a dodo who accidentally applied it to the wrong forum.

1 Like
4

Try the following

#showtooltip
/cast [mod,harm][mod,@focustarget,harm,nodead][mod,@focus,harm,nodead][mod,@targettarget,harm,nodead][mod] Holy Fire; [harm][@focustarget,harm,nodead][@focus,harm,nodead][@targettarget,harm,nodead] Smite

Also, does right clicking vs left clicking change the behavior?

5

Appreciate the response–logging in to attempt now.

6

Okay, lemme see if I can word all of this properly, hah.

Pressing shift+3 on the keyboard fires Holy Fire.
Clicking on the action button fires Smite.
Shift+clicking on the action button fires Holy Fire.
Shift+rightclicking on the action button fires Holy Fire.

So I’m glad I can at least fire Smite from this macro now… but I used to be able to smash shift+3 and fire Smite. I just can’t figure out why that would change.

Going back to my old macro to attempt right/left click…

Okay, right or left click while holding down shift does nothing different. It fires Holy Fire regardless.

I clicked on the macro and it fired Smite, so it seems to behaving just like the one you posted.

I dunno if I’m an idiot and didn’t properly test it last night, but I could not get it to launch Smite last night so idfk wtf I’ve done differently here.

Why they gotta go breaking my macros? lol

7

Maybe I need to just come up with a macro that fires Holy Fire on click and otherwise casts Smite.

8

Specify the mod for Holy Fire (not shift) instead of making it encompass all mods.

#showtooltip
/cast [mod:alt,harm][mod:alt,@focustarget,harm,nodead][mod:alt,@focus,harm,nodead][mod:alt,@targettarget,harm,nodead][mod:alt] Holy Fire; [harm][@focustarget,harm,nodead][@focus,harm,nodead][@targettarget,harm,nodead] Smite

alt+bind = Holy Fire
bind = Smite

9

I promise you I appreciate you and am not just trying to be difficult <3

My dumb hands won’t operate the ALT key. Shift is the only mod key I can reliably use–again, dumb hands lol

I’m just puzzled as to why this would’ve suddenly changed.

10

Eh, ctrl is right beside it so you can probably fat finger both if ya try :wink:

11

A lot of little things changed with the UI update, and the way you were doing things was a bit unusual. It was basically an edge case they didn’t account for when they were making changes.

So, I think that the best way to proceed is to find a new way to get your old results.

Here is my understanding of the old behavior:

  • shift+3 casts smite, using the target priority listed in the macro.
  • clicking the button while holding shift casts holy fire with the target priority listed in the macro.

So, the easy option would be to just separate them into different buttons. The new UI added 3 new button bars you can use. As you weren’t using a keybind to cast holy fire, you can just put the following macro on a new button without a keybind set up.

#showtooltip
/cast [@target,harm][@focustarget,harm][@focus,harm][@targettarget,harm][] Holy Fire

You won’t have to hold down the shift key to cast it when you click the button. (Although as long as you don’t have shift set up as the modifier for self cast, focus cast, or mouseover cast in the interface options, holding shift while clicking it shouldn’t stop it from working.)

Then just put a smite macro on your Shift-3 bind:

#showtooltip 
/cast [@target,harm][@focustarget,harm][@focus,harm][@targettarget,harm][] Smite
1 Like
12

Looking at your macro again, your logic order’s a bit janky. I recommend swapping the focus and focustarget condition sets so it behaves properly. As it stands, if you have a hostile focus, and they’re targeting another hostile target, you’ll cast on focustarget instead of focus.

#showtooltip
/cast [mod,harm] [mod,@focus,harm,nodead] [mod,@focustarget,harm,nodead] [mod,@targettarget,harm,nodead] [mod] Holy Fire; [harm] [@focus,harm,nodead] [@focustarget,harm,nodead] [@targettarget,harm,nodead] [] Smite

If you follow Udiza’s recommendation:

#showtooltip 
/cast [harm] [@focus,harm,nodead] [@focustarget,harm,nodead] [@targettarget,harm,nodead] [] Smite
13

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.