So what’s the best enchant?
It varies.
If you only raid, and use the icefury build. Torrent of the Elements pulls out ahead often. It does not buff earthquake, though.
Over all, it can vary depending on your specific stats. I personally use Vers.
Icy Veins says Crit. So I run crit.
Makes sense in PVP to run either vers or Torrent of Elements - crits only help with flame shock ticks (meh) and only a few times a fight, if that, with ES. Your meatballs are critting anyway. Vers at least buys you some output and some damage reduction.
If you are not swimming with each piece of new gear you get them it really doesn’t matter. In most cases haste or crit is your best bet. However sometimes the elemental enchant pulls ahead by maybe 30 sos total. Run sims often.
Sim your gear.
Just from what I have seen from other people gearing and through my own progression of gearing when you reach 20-22% crit (especially with crit/NH azerite pieces) crit starts to lose value and Versatility takes over.
Now if you are running the EotE/MotE/IF/SK build; once crit starts losing value, Torrent of the Elements will actually pull ahead.
Yes, always sim your gear. GENERALLY you want crit/haste/vers to be about even. This is a very general rule of thumb.
This means if you have a lot of crit/vers, haste may be your best option.
Also take note of what content you are doing. M+/Raiding/PVP.
For example
https://www.raidbots.com/simbot/report/8MZdC8YECLZomsWw1LJTc6
That is my sim comparing Vers, Crit, Haste, and Torrent of the Elements.
Torrent gives me about 80 more SIM DPS than the second best option. But I also enjoy running M+, whilch makes Torrent nearly useless as it does not effect Earthquake damage.
I personally take the number 2 option, of Vers. As it can help me in both spots and give me some slight bonus DR as well.
For reference as well I am at the following stats
Crit 750 (15%)
Haste 1379 (21%)
Vers 1090 (13%)
Mastery 411 (26%)
This gives me stat weights of the following:
INT 2.33
CRIT 2.52
HASTE 2.4
MASTERY 2.12
VERS 2.5