Annons blocked since this week's reset

Fizzlemizz-azjolnerub · September 29, 2023, 4:58pm

The bug introduced with the ClearTarget fix seems to be ongoing.

Random blocked actions as of 10.1.7.51421

opened 03:18PM - 21 Sep 23 UTC

Mainline PTR Regression Mainline Classic High Priority

As of the 10.1.7.51421 hotfix build to fix protections on ClearTarget there's be…en a number of reports where unrelated addons are getting blamed for blocked or forbidden actions in locations that are seemingly nonsense - such as in return statements of functions, or in the iterator of `for ... in pairs` loops. This ticket is mostly to just collect the various reports and figure out if there's some common thread between everything. The issue itself also reportedly occurs on the 10.2.0 PTR. ## Test case A reproducible test case has been worked out: [WowUIBugs_483.zip](https://github.com/Stanzilla/WoWUIBugs/files/12699831/WowUIBugs_483.zip) The preconditions for this test case are that the client version is 10.1.7.51421 and that the player logging in must be located in the outdoor section of Valdrakken. The author of this test case has noted that on some client startups this error may not be 100% reproducible, and that they sometimes had to fully exit and restart the client a few times before it'd work. Shortly after logging in - or reloading the UI - you'll get an addon action blocked popup with the taint log suggesting an unnamed action was blocked, despite the addon itself calling no secure functions. ``` 9/22 11:33:13.765 An action was blocked because of taint from WowUIBugs_483 - 9/22 11:33:13.765 Interface/AddOns/WowUIBugs_483/WowUIBugs_483.lua:21 work() 9/22 11:33:13.765 Interface/AddOns/WowUIBugs_483/WowUIBugs_483.lua:44 ``` Line 21 in the above taint log corresponds to a table allocation: ```lua local data = {} ``` ## Common things At the moment the only common aspect between all but one of these reports is that seemingly whenever the blocked action occurs, the client is in a state where the [debugstack](https://wowpedia.fandom.com/wiki/API_debugstack) API is locked down and made to return a nil value. We know this restriction applies during execution of `__gc` finalizers, but no reported cases have addon code making use of these. The other possibility is aspects of scenescript lockdown are going awry, as a number of reports have noted the issue occurs more frequently (or only at all) in Valdrakken. ## Action blocked because of... table creation? The following taint log supplied by @plusmouse doesn't name what action was blocked. The source line being blamed is a return statement where a table is constructed: https://github.com/Auctionator/Auctionator/blob/040975cfccda96a132a4dfbcae533f227fe3d9ca/Source_Mainline/Utilities/ItemInfoFromLocation.lua#L29 ```lua return { itemKey = itemKey, itemLink = itemLink, count = itemCount, iconTexture = icon, itemType = itemType, location = location, quality = quality, classId = classID, auctionable = C_AuctionHouse.IsSellItemValid(location, false), bagListing = quality ~= Enum.ItemQuality.Poor or Auctionator.Utilities.IsEquipment(classID), } ``` ``` 9/21 14:41:36.519 An action was blocked because of taint from Auctionator - 9/21 14:41:36.519 Interface/AddOns/Auctionator/Source_Mainline/Utilities/ItemInfoFromLocation.lua:29 ItemInfoFromLocation() 9/21 14:41:36.519 Interface/AddOns/Auctionator/Source/Tabs/DataProviders/Bag.lua:63 Frame:LoadBagData() 9/21 14:41:36.519 Interface/AddOns/Auctionator/Source/Tabs/DataProviders/Bag.lua:13 Frame:Reload() 9/21 14:41:36.519 Interface/AddOns/Auctionator/Source/Tabs/DataProviders/Bag.lua:93 ``` Additionally there's another instance of this one - though not returning a table but assigning a newly constructed one: https://github.com/rossnichols/LibSerialize/blob/5a1cbe3d7df11ac432252f05d0ac9239d87fdbbc/LibSerialize.lua#L760 ```lua value = {} ``` ``` 9/20 20:55:36.356 An action was blocked because of taint from PointBlankSniper - 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:760 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:765 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:807 _ReadPair() 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:749 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:1351 9/20 20:55:36.356 pcall() 9/20 20:55:36.356 Interface/AddOns/PointBlankSniper/Libs/LibSerialize/LibSerialize.lua:1362 Deserialize() ``` ## Action blocked because of... string concatenation? The following taint log supplied by @glassleo doesn't name what action was blocked. The source line in question is the following from this addon - note that the committed version of the code doesn't quite match what was used in game; line 146 in the taint log corresponds to line 144 in this commit: https://github.com/glassleo/ZigiAuras/blob/8dced36290b781b317141b0004a54f16222f7b27/!ZigiAuras/ZigiAuras.lua#L144 ```lua tstr = tstr .. c ``` ``` 9/21 16:04:39.873 An action was blocked because of taint from !ZigiAuras - 9/21 16:04:39.873 Interface/AddOns/!ZigiAuras/ZigiAuras.lua:146 Transliterate() 9/21 16:04:39.873 return function():3 9/21 16:04:39.873 xpcall() 9/21 16:04:39.873 Interface/AddOns/WeakAuras/WeakAuras.lua:4579 RunCustomTextFunc() 9/21 16:04:39.873 Interface/AddOns/WeakAuras/RegionTypes/Text.lua:255 ?() 9/21 16:04:39.873 Interface/AddOns/WeakAuras/SubscribableObject.lua:90 Notify() 9/21 16:04:39.873 Interface/AddOns/WeakAuras/RegionTypes/RegionPrototype.lua:641 ``` ## Action blocked because of... a `for ... in` iterator? A number of random addons are getting blamed for blocked actions in `for .. in` iterators - with some of these confirmed to just be using pairs/next as the iterator function. An example from TSM: ```lua for itemString, state in pairs(private.pendingItems) do ``` ``` 9/20 19:33:29.666 An action was blocked because of taint from TradeSkillMaster - (for generator)() 9/20 19:33:29.666 Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemInfo.lua:1178 _callback() 9/20 19:33:29.666 Interface/AddOns/TradeSkillMaster/LibTSM/Util/Delay.lua:100 value() 9/20 19:33:29.666 Interface/AddOns/TradeSkillMaster/External/LibTSMClass/LibTSMClass.lua:332 _CheckIfDone() 9/20 19:33:29.666 Interface/AddOns/TradeSkillMaster/LibTSM/Util/Delay.lua:123 ``` And one blaming WeakAuras - no taint log, unfortunately: ![image](https://github.com/Stanzilla/WoWUIBugs/assets/287102/3aa4ed04-074b-4c35-a06b-1191fdf96ce6) ## Action blocked when... resuming a coroutine? This one is a bit special - where all the others occurred in states where stack traces weren't permitted (`debugstack()` returned nil), this one didn't run into that restriction. This reportedly occurred quite often while in Valdrakken. ``` 1x [ADDON_ACTION_FORBIDDEN] AddOn 'ZGV-dev' tried to call the protected function 'resume()'. Stack: !BugGrabber/BugGrabber.lua:521: in function <:521> [C code]: ? ZGV-dev/ZygorGuidesViewer.lua:998: in function 'StartupStep' ZGV-dev/MasterFrame.lua:7: in function <:5> ```