Dumbass was great “These new Forsaken can be a little bit slow” so was Johnny Awesome! The scream he let out when you ran him past the grave of “Twinkles” The sparklepony still makes me laugh!
Chromie, her voice is so sexy and charming. Would date for sure!
I will always have a soft spot in my heart for Sesebi.
Lor’themar is always a voice of sanity in the Horde.
I have in the past. It’s just it was so long ago
I have not communed with Sesebi in so long. I had to go and /pet her. Being with her is so relaxing.
That one I had to look up, but I see the attraction.
Bwonsamdi. He’s marriage material 
Plague Deviser Marileth. The hugs and slime obsession won me over.
Theotar, of course - he’s just fun. As is Marileth. But I think I’ll always have a soft spot in my heart for Runas.
I am hesitant to say because every time I pick a favorite they meet an untimely death.
I like those undead pirates from Vol’dun. I guess the one big thing I liked about BfA was some of the side characters, since it had a kind of a mild pirate theme going on anyways. I’ve always liked the little pirate ports they’ve had throughout the game. The always have my fav NPCs and questlines.
As far as Shadowlands, Theotar was cool. There are others, but I can’t think right now.
I always liked the death knights Thassarian and Kolfax. (korfax?). You really got a sense of their shared brotherhood and the regret with what they were forced to do against the other.
Budd. Will always be forever Budd.
https://youtu.be/0aQ4trp6ha4
Jaina Proudmoore.
I’m taking no further questions.
Bwonsamdi.
Genn because he’s a bad a$@ old wolf. 
I love Vorpalia.
“You realize I am a floating sword, do you not? I can easily move between these massive cell grates.”
Ysera. Don’t even get me started on when we had to kill her in Val’sharah. 