Excluding Thalassian elves who heavily use a different kind of magic, is it just an inevitability that your average Thalassian elf will have eyes of a golden hue because of the Sunwell’s influence?
By the way, by “Thalassian elf” I mean any elf that Thalassian; not just the elves that are in Quel’thalas right now.
There seems to be a proclivity in Thalassian elves’ eyes - and one could argue, in Kaldorei and so perhaps all elves’ eyes - to attune to whatever magical energy source they’re regularly exposed to. There also seems to be a range limit on their proximity to their magical source, hence the need to make a Sunwell at all.
I’d argue no, Thalassian elves who do not linger in Quel’thalas won’t have their eye color influenced by the Sunwell.
Definitely not the Void Elves 
In all seriousness, overall, I’d suggest no. This is purely theorycrafting, it should be noted. I don’t think we’ve been given a definite lore answer on this. But I don’t think golden eyes are an inevitability at all.
After the Sunwell was corrupted by Arthas, and then destroyed by Kael’thas not long afterward, the remaining elves of Quel’thalas found ways to cope with a lack of their traditional power source (to which they were all addicted).
Those who would become the Blood Elves siphoned magic from other sources, such as living magical creatures (like mana wyrms) and fel energy. Those who would become Void Elves much further down the line continued this philosophy, but specifically using void energy. Those who would become Wretched actually siphoned too much, and lost themselves to the addiction. Those who would become High Elves actually managed to quit cold turkey, and through sheer willpower, were able to quit entirely… surviving without a need to be constantly connected to a source of magic (though I believe it’s implied many of them died during this process).
With that in mind… many variants of elves have been able to last for a few years at least without connecting directly to the Sunwell.
So, my theory is this:
Most Blood Elves will eventually get golden eyes. Some will not, specifically warlocks and the like who may still be getting by on fel energy.
Some High Elves will eventually get golden eyes, though due to a lack of regular proximity to the Sunwell this will likely take longer than the average Blood Elf. That said, High Elves had an incredibly strong willpower to quit, and some may choose to simply shut themselves off from its power deliberately, as many addicts who’ve managed to quit an addiction will do. I suspect there are High Elves out there who fear the Sunwell’s influence, given that it remains firmly in Horde territory it could be something that is used against them.
Void Elves will not, in any form, get golden eyes. They are all using the void directly, which would very much nullify any of the effects of the Light. I believe this to be true of the original void elves who got partially etherealed, as well as the ones who’ve voluntarily chosen to study the void.
Elves eye color change with whatever magic they happen to be absorbing/using
Blue means mana/arcane. High Elves use Arcane more than any other type of magic. Certainly more than light, Feline or Void. So their eyes will remain blue for the foreseeable future.
Dude quiet down you’re going to attract druids
My Blood Elf Dinosaur Hunter got golden eyes because she took a boat to Zandalar, and saw that it was very dinosaur and got excited, and thus the fel taint was purged from her body by the Holy Light of the Dinosaurs.
She now lives in Zandalar.
Officially it’s hard to say.
Blood elf eyes are just mood rings.
No I will not be taking questions at this time.
I seem to recall, even in ye olde days of lore interviews with Metzen, he expressed uncertainty over the whole Sunwell thing. I think he said it has infinite range, but he didn’t sound certain.
wait you guys still keep up with lore?
i’m sorry for your loss
Regarding the Sunwell’s range, thanks to a question that was asked at a previous Blizzcon panel, we know it has essentially a boundless range. In other words, a Thalassian elf could be anywhere in existence; Outland, another timeline, etc… and the Sunwell’s connection to a Thalassian elf isn’t lost.
The Sunwell provides great 5G coverage; anywhere—anytime.
but can it see why humans love Cinnamon Toast Crunch?
Considering it was made from dumping a singl vial of the original Well of Eternity into a lake, they shouldn’t have become deprived of the original well’s magics and turned into quel’dorei.
Not trying to argue, but Blizzard is absolutely garbage with their lore.
I thought that was more to do with the corruption they faced in Tiristfal Glades, due to the cursed buried evil below xD
I always assumed the physical changes had more to do with becoming diurnal rather than nocturnal, in combination with the Sunwell, which might have had a different energy than the original Well of Eternity.
To my understanding, the Sunwell works like this.
Sating Magic Addiction: Unlimited range. Doesn’t matter where you are in the entire cosmos, if the Sunwell is up, your magic addiction is sated.
Empowering Mages: Limited range. You need to be within spitting distance of the Sunwell to empower yourself with it to make your spells more powerful.
Blood Knights and the Light: Unlimited range. If you’re a Blood Knight getting their Light from the Sunwell, it doesn’t matter where you are, the Sunwell provides.
It’s worth noting it’s hard for the High Elves to draw upon its energies though. They felt it was very different and even alien once it was restored with the Light, in the Lor’themar short story.
they don’t call them high elves for nothin’, hippie stoner bloodthistle smoking jobless freaks!
I’m sorry for your lores.