Shadow priest or affliction warlock in shadowlands?

Play both, but don’t be surprised if you play lock more as you have three bites at the quality dps spec apple. The multi spec perks of a pure dps class are hard to beat, they can usually find a good spec for any content, whereas SWP, Ret, WW, etc can’t say the same.