There is much more nuance to current Enhance than just not capping and refreshing flame shock — dependent on your legendary, as well as your talents, the inclusion of adds, etc.
BFA’s damage was built around feast or famine stormstrikes, which just felt bad. You had all these buttons to press that did minimal damage, and only when you were feasting on stormbringer did things feel meaningful.
Currently, there are 3 different specs all viable for single target that compete: Doom Winds, Frost Witch, Wolf Bones — all of them change priorities
If everything is coming off cd at the same time, you make a conscious decision which to press. If a second add runs into range, crash lightning shoots up higher on the priority list so you can start cleaving. Doom Winds allows for great burst during burst phases where you might hold some abilities you otherwise wouldn’t ( Sludgefist is a good example as it times up really nice with his debuff). Wolf Bones alters priorities based on what wolves you have out (particularly for lava lash).
The spec is also just not gated by anything other than cooldowns. BFA was gated by how well you managed your maelstrom. And for a class that had no real resource outside cooldowns for six expansions before that — one that had streamlined the Maelstrom Weapon stacks system to feel great (MoP/WoD) — it felt terrible.
Did it bring in new people? Sure. But it was largely hated by the shaman community, as seen by it being taken away and replaced.
Thematically, you might call us warriors that use the elements — but we are shaman, not warriors — taking away iconic spells hurts the flavor. Furthermore, Enhance has spent a large time of its life feeling like a melee who is using their attacks to charge up to a big nuke spell. Currently, there is a balance around where our dmg comes from, that shifts depending on what legendary you use. This is ultimately because one of the biggest complaints about MWSx5 was overcaps and too much dmg tied to Lightning Bolt. So in SL, they fixed overcaps by bringing the stack to 10 instead of 5, and adjusted our dmg to not completely rely on a 5 stack nuke LB.
I agree that this is one of the valid points of criticism (the other being mana regeneration in PvP). But I also think this is done in purpose, specifically for pvp. Making Enhance fully gcd locked hurts their damage if they have to use utility spells (purge, cleanse, totems) in the pvp format. Elemental doesn’t have this issue in regards to PvP.