That is flavor text. If youre gonna side with blizzard on this one then we should be losing buffs that go away on death and getting a death event too.
Some other tooltips that would need adjusting:
Purify/Improved Purify should say All dispellable magic [and disease) effects.
Guardian Spirit should say that the angel sacrifices itself and heals the target for 40% of their health or 200% of the casters health, whichever is smaller. It doesnt restore a target to 40% hp, this number gets reduced by things like mortal strike.
Divine hymn tooltip says it does reduced healing beyond 5 targets, but never mentions that pets are ignored for this nor does it mention full hp targets.
Gales of song claims to give pom stacks every 1 second (with no haste) when channeling divine hymn, but in reality it just gives the pom stacks every tick, which is instantly and then every 1.25s after (with 0 haste).
Angelic touch says it makes heals do 220% crit effect instead of 200%. But things like tauren racial and pvp mod affects both of these numbers. In reality it just increases the effectiveness of crits by 10%.
Trail of light mentions it heals your previous flash heal target, but never mentions that it doesnt include your current target in that. If you heal the same person twice in a row, the trail heals the same person twice in a row as well.
Ultimate Serenity claims it heals 4 additional targets for 15% of serenitys healing done, but what it actually does is proc a separate heal effect called ultimate serenity that has a coefficient of ~13% of serenity. This means casting guardian spirit on someone and then using serenity on them does not increase the heal of ultimate serenity’s cleave. This cleave also rolls its own crit chance and its own spell variance. Tldr: has nothing to do with serenitys healing done.
Pre-emptive care claims to increase the duration of renew by 40%. It does do this for Lights Resurgence renews, but for Lasting Words renews it actually only increases their duration by 25%.
Waste No Time reduces the base cooldown of prayer of mending by 1.5s. Not its cooldown as it suggests. Completely overlooks that the spell has a hasted cooldown.
Piety claims that 15% overhealing done gets redistributed, but not all overhealing actually does. For example, piety overhealing doesnt feed back into piety even though tooltip suggests it does.
Unfolding vision makes expiring poms lose 2 stacks and jumps to a new player instead of vanishing altogether. Say your prayers says pom has a chance to not consume a charge when jumping to a new player. Yet these talents do not interact.
Body and soul says that pom and leap of faith increases movespeed by 3s. But what they really mean is that poms from twinsight, initial cast of pom, and poms generated by Gales of song increase your movement speed. No matter how you interpret the tooltip theres an exception.
Apotheosis says it resets the cooldown of your holy words, but what it actually does is give cooldown reduction equal to the cooldown of each of your holy words. This means you only regenerate 1 charge if you have miracle worker talented.
Unwavering Will doesnt just reduce cast time, it reduces gcd too even when surge of light is instant cast. This isnt true of other cast time reductions like Focused Outburst
Angelic Bulwark just completely ignores its tooltip. I have absolutely no idea what triggers its effect, but I can tell you it is not when youre brought below 30% hp like it says. Sometimes itll trigger at 70% hp, sometimes youll be at 20% hp and it won’t trigger.
Resurrection and Mass Ressurection say they cannot be cast in combat. And while its true that neither can start their cast in combat-- resurrection can actually finish its cast in combat as long as you dont take any damage. Mass rez cannot.
Haste buffs in general that increase your haste% do so multiplicatively. The other stats do so additively. For priest this means power infusion actually increases haste by a factor of 1.2. If you have 50% haste, pi would bump that to 80% not 70%.
You get the idea, tooltips cannot be used as proof of intention or design for anything. It is and will always be flavor text. Are some of the above actually just bugs and not intended? Probably. But spirit of redemption/restitution absolutely belongs with the rest of the list considering its behavior tries to play both sides of death simultaneously.
Also that list is not exhaustive, there are many more examples of this, including from specs that arent holy priest.
Also two can play that game anyway, if you read Spirit of Redemption tooltip, it says ““when the effect ends you die.”” But the death timer gets triggered when you enter spirit not when it expires. If you die to enter spirit and you also die when you exit spirit why doesnt it trigger the death twice every time? Shouldnt restitution then cost 3 deaths if you die to enter spirit, die when spirit expires revive from restitution (with no option to decline btw) and then die again from the party wipe?