On release Macro

[Noroud-proudmoore]

Was wondering if it was possible to have an on release macro for traps, where clicking down would bring up the reticle area indicator, and then releasing would then cast the trap at the cursor spot? Such that I could it down and then release, for a much smoother process.

[Adreaver-undermine (Adreaver)]

@Gello has you covered. There are some caveats he can explain better than I, but check this post:

@Gello-hyjal

This is how my warriors heroic leap:

local key = "SHIFT-C"
if select(2,UnitClass("player"))=="WARRIOR" then
   local button = CreateFrame("Button","HeroicLeapOnUp",nil,"SecureActionButtonTemplate")
   button:RegisterForClicks("AnyDown","AnyUp")
   button:SetAttribute("type","macro")
   SecureHandlerWrapScript(button,"OnClick",button,[[
     if down then
       self:SetAttribute("macrotext","/cast heroic leap")
     else
       self:SetAttribute("macrotext","/stopspelltarget\n/cast [@cursor] heroic leap")
     end
   ]])
   button:RegisterEvent("PLAYER_LOGIN")
   button:SetScript("OnEvent",function(self,event,...)
     SetOverrideBindingClick(self,true,key,"HeroicLeapOnUp")
   end)
end

Rather than hitting a key, moving the reticle where you want to leap and then clicking the mouse; with this you press the key down, move the reticle where you want to leap and then release the key. You’ll leap to wherever the mouse was when you let go. (The @cursor does the same thing but without the ability to use the reticle to target a spot.)

In this scenario you can choose an OnKeyUp or OnAttributeChanged or probably a few other options that are valid during the hardware events that caused them. The following uses OnAttributeChanged because it’s one you wouldn’t intuitively expect to work:

local key = "SHIFT-C"
if select(2,UnitClass("player"))=="WARRIOR" then
   local button = CreateFrame("Button","HeroicLeapOnUp",nil,"SecureActionButtonTemplate")
   button:RegisterForClicks("AnyDown","AnyUp")
   button:SetAttribute("type","macro")
   SecureHandlerWrapScript(button,"OnClick",button,[[
 if down then
   self:SetAttribute("macrotext","/cast heroic leap")
 else
   self:SetAttribute("macrotext","/stopspelltarget\n/cast [@cursor] heroic leap")
 end
   ]])
   button:RegisterEvent("PLAYER_LOGIN")
   button:SetScript("OnEvent",function(self,event,...)
 SetOverrideBindingClick(self,true,key,"HeroicLeapOnUp")
   end)
   button:SetScript("OnAttributeChanged",function(self,attribType,attribValue)
  if (attribValue or ""):match("^/stopspell.+heroic leap$") then
      if GetSpellCooldown(6544)==0 then
          SendChatMessage("Hi there","say")
      end
  end
   end)
   button:SetScript("PostClick",function(self) self:SetAttribute("macrotext",nil) end)
end

The PostClick is there so that if the attribute changes by some other means it won’t trigger a chat when you’re not leaping. For a more practical use I recommend OnKeyUp.

[Adreaver-undermine (Adreaver)]

Actually, after mucking around with this a while ago and failing to get it working (because I was modifying the addon in the _beta_ folder rather than _retail_ >.<), I took the time to figure it out. Enjoy.

--Trap On Release
local key = "PageDown"
if select(2,UnitClass("player"))=="HUNTER" then
   local FreezingTrapOnUp = CreateFrame("Button","FreezingTrapOnUp",nil,"SecureActionButtonTemplate")
   FreezingTrapOnUp:RegisterForClicks("AnyDown","AnyUp")
   FreezingTrapOnUp:SetAttribute("type","macro")
   SecureHandlerWrapScript(FreezingTrapOnUp,"OnClick",FreezingTrapOnUp,[[
     if down then
       self:SetAttribute("macrotext","/cast Freezing Trap")
     else
       self:SetAttribute("macrotext","/stopspelltarget\n/cast [@cursor] Freezing Trap")
     end
   ]])
   FreezingTrapOnUp:RegisterEvent("PLAYER_LOGIN")
   FreezingTrapOnUp:SetScript("OnEvent",function(self,event,...)
     SetOverrideBindingClick(self,true,key,"FreezingTrapOnUp")
   end)
end

local key2 = "CTRL-PageDown"
if select(2,UnitClass("player"))=="HUNTER" then
   local TarTrapOnUp = CreateFrame("Button","TarTrapOnUp",nil,"SecureActionButtonTemplate")
   TarTrapOnUp:RegisterForClicks("AnyDown","AnyUp")
   TarTrapOnUp:SetAttribute("type","macro")
   SecureHandlerWrapScript(TarTrapOnUp,"OnClick",TarTrapOnUp,[[
     if down then
       self:SetAttribute("macrotext","/cast Tar Trap")
     else
       self:SetAttribute("macrotext","/stopspelltarget\n/cast [@cursor] Tar Trap")
     end
   ]])
   TarTrapOnUp:RegisterEvent("PLAYER_LOGIN")
   TarTrapOnUp:SetScript("OnEvent",function(self,event,...)
     SetOverrideBindingClick(self,true,key2,"TarTrapOnUp")
   end)
end

local key3 = "SHIFT-PageDown"
if select(2,UnitClass("player"))=="HUNTER" then
   local BindingShotOnUp = CreateFrame("Button","BindingShotOnUp",nil,"SecureActionButtonTemplate")
   BindingShotOnUp:RegisterForClicks("AnyDown","AnyUp")
   BindingShotOnUp:SetAttribute("type","macro")
   SecureHandlerWrapScript(BindingShotOnUp,"OnClick",BindingShotOnUp,[[
     if down then
       self:SetAttribute("macrotext","/cast Binding Shot")
     else
       self:SetAttribute("macrotext","/stopspelltarget\n/cast [@cursor] Binding Shot")
     end
   ]])
   BindingShotOnUp:RegisterEvent("PLAYER_LOGIN")
   BindingShotOnUp:SetScript("OnEvent",function(self,event,...)
     SetOverrideBindingClick(self,true,key3,"BindingShotOnUp")
   end)
end

You can add more in the same format for other ground-targeted spells (e.g. Flare, Volley, Wild Spirits, Resonating Arrow, etc). Make sure to adjust the keybinds to what you want to use.

[Noroud-proudmoore]

Thanks for the reply! But am I missing something? The text is too long and wont fit into a single macro…

[Gello-hyjal]

You can turn it into an addon by pasting it into https://addon.bool.no/

The code defines the keys too. You may want to change them to suit your preferred keybinds.

[Adreaver-undermine (Adreaver)]

Again, @Gello has you covered. I thought the addon.bool.no bit was covered in the linked post, but on rereading I think it was mentioned elsewhere in that thread.