DragonFlight CLICK bindings broken?

it did up until about 3 days ago.

its now “broken” in such a way that i think only blizzard can fix it - presuming they believe its a bug and not the new normal.

1 Like

button = CreateFrame(“Button”,“LAs1”,nil,“SecureActionButtonTemplate”)
button:SetAttribute(“type”,“macro”)
button:SetAttribute(“macrotext”,’/castrandom Spectral Tiger, Black War Tiger’)

While this worked yesterday, and last expansion come to it, /click LAs1 does nadda now. Suggestions?

Try /click LAs1 LeftButton

If space is limited in the macro you can do /click LAs1 X and it should work too.

A couple beta/ptr builds ago, the mouse button argument (LeftButton) was needed on 10.0.2 (beta) but not 10.0.0 (ptr). In the next build it was not needed on either. In last week’s build it was needed on 10.0.0 but not 10.0.2.

So be aware this may change.

2 Likes

Ah! It seems you MUST pass the Down value. mutter At least, that’s my guess

Many, many thanks!

I suppose it didn’t matter until there were spells needing to know this. Still, the default could have been left at zero.

Thanks for this!

Before:

local buttonName = "BinderMount1_"..value.spell

button = CreateFrame("Button", buttonName, UIParent, "SecureActionButtonTemplate")

button:SetAttribute("type", "spell")
button:SetAttribute("spell", value.spell)
button:SetAttribute("unit", "player")

local status = SetBindingClick(value.key, buttonName)

After:

    local buttonName = "SsiardBinderMount1_"..value.spell

    button = CreateFrame("Button", buttonName, UIParent, "SecureActionButtonTemplate")

    button:SetAttribute("type", "spell")
    button:SetAttribute("spell", value.spell)
    button:SetAttribute("unit", "player")
    button:RegisterForClicks("LeftButtonDown", "LeftButtonUp")

    local status = SetBindingClick(value.key, buttonName, "LeftButton 1")

Oooooh thank you. I know next to no LUA but I’ve been “updating” a defunct addon for myself for like 10 years and 10.0 finally killed it. After digging through the code and this post I think I’ll be able to fix it now since it uses /Click.

If anyone happens to want to fix and re-up this addon for others…
https://www.curseforge.com/wow/addons/whistle

I’ll consider it if this fix works when I can get home to test it.

I was trying to fix an older addon that is no longer maintained by the original author.
/console ActionButtonUseKeyDown 0 Worked for me on the live pre-patch… I say this after having struggled for hours to find an alternative for button:WrapScript(button, 'OnClick', castedAbility)

I have a feeling we’re gonna get slapped with a new "working as intended." lol

local f = CreateFrame("Button", "ClickTest", UIParent, "SecureActionButtonTemplate")

f:RegisterForClicks("AnyDown","AnyUp")
f:SetAttribute("type","spell")
f:SetAttribute("spell","Rain of Fire")

print("ActionButtonUseKeyDown:",GetCVar("ActionButtonUseKeyDown"))

On 10.0.0 (live and PTR):

When ActionButtonUseKeyDown is 0:

  • /click ClickTest works
  • /click ClickTest LeftButton doesn’t work

When ActionButtonUseKeyDown is 1:

  • /click ClickTest LeftButton works
  • /click ClickTest doesn’t work

On 10.0.2 (beta);

Regardless of ActionButtonUseKeyDown:

  • /click ClickTest works
  • /click ClickTest LeftButton doesn’t work

It’s a mess.

4 Likes

Seems to be fixed for my addon ActionbarPlus. I logged on today in PTR. The “ActionButtonUseKeyDown” settings are now working. I’m going to poke around and see what’s changed.

I take that back. Still a mess.
I can get the buttons to work as it was before with ActionButtonUseKeyDown set to true.
I don’t know how to solve the part where my addon will stop working if the user sets the ActionButtonuseKeyDown to false. OMG :slight_smile:

Now on 10.0.2:

When ActionButtonUseKeyDown is 0:

  • /click ClickTest works
  • /click ClickTest LeftButton doesn’t work

When ActionButtonUseKeyDown is 1:

  • /click ClickTest LeftButton works
  • /click ClickTest doesn’t work

/sigh

1 Like

A new variation in today’s 10.0.2 beta build:

When ActionButtonUseKeyDown is 0:

  • /click ClickTest works
  • /click ClickTest LeftButton works

When ActionButtonUseKeyDown is 1:

  • /click ClickTest LeftButton doesn’t work
  • /click ClickTest doesn’t doesn’t work
1 Like

pro…gress?

So I got this Macro on Beta:

/click MultiBarBottomLeftButton4 RightButton
/cast [button:1] Freezing Trap
/cast [button:2,@player] Freezing Trap

It’s placed on MultiBarBottomLeftButton4 , which is keybound to F4.
When I press F4 on the keyboard it places a Freezing Trap at my feet.
When I click the button I get the green placeholder so that I can place it wherever I want.
It’s working great.

But on Live it doesn’t work at all :frowning:
Will it work when DF is officially launched?

The above appeared unchanged this morning, on both PTR and beta (and the latter’s build was dated Nov 10). But testing further, when ActionButtonUseKeyDown is 1 it looks like we need to pass not only the button but a 1 for that down:

When ActionButtonUseKeyDown is 0:

  • /click ClickTest works
  • /click ClickTest LeftButton works
  • /click ClickTest LeftButton 0 works
  • /click ClickTest LeftButton 1 doesn’t work

When ActionButtonUseKeyDown is 1:

  • /click ClickTest doesn’t work
  • /click ClickTest LeftButton doesn’t work
  • /click ClickTest LeftButton 0 doesn’t work
  • /click ClickTest LeftButton 1 works

So for addons that depend on /click to use items or cast spells, they will need to append the GetCVar(“ActionButtonUseKeyDown”) to the /click in addition to a mouse button. (If you register AnyUp,AnyDown you don’t need to spell out LeftButton. In Select I’m doing “/click (button) X 1” instead of “/click (button) LeftButton 1”.

3 Likes

NOW what did they do? Not working again. :face_with_symbols_over_mouth: patch day!

I was able to get it to work like this:

/click ButtonName LeftButton True

Any other details? This doesn’t work for me with

/click ActionButton8 Button5 True

Something like:

/click MultiBarRightButton9

works as expected. Whereas , as described above

button = CreateFrame(“Button”,“LAs1”,nil,“SecureActionButtonTemplate”)
button:SetAttribute(“type”,“macro”)
button:SetAttribute(“macrotext”,’/castrandom Spectral Tiger, Black War Tiger’)

Worked yesterday, and last expansion come to it, /click LAs1 now seems to require LeftButton True to do anything which makes /click far less useful.

Is there something I can do in the button descriptor to eliminate this?

Edit 1: 1 will work in place of True

Edit 2: Upon further investigation (ie, reading another Gello post), it appears, at present, that while you don’t need to register for AnyUp and/or AnyDown, you do now need to pass: “(anything) 1” for /click to work, tho why this isn’t true for default buttons is unclear (to me anyway)

I’m not sure of all the options but, “ActionButton8” may not be an actual button frame name. I use ElvUI, so mine are all patterned logically. The Default UI is not. You’ll need to use /fstack to discover it. Also, I don’t think you can use arbitary mouse buttons in there. So far as I know, only LeftButton and RightButton work (or worked). Gello will likely know more there.