[Bug] Berserker Stance

[Ekbert-sargeras]

Thanks to extensive testing done on the beta by Puffymuffins, Towneh, and Vilius over at the classic warrior discord, we’ve encountered what appears to be a pretty significant bug with Berserker Stance. Against +3 level mobs, Berserker Stance’s +3% crit bonus is not applying to our attacks and as a result our effective crit chance is 3% lower than it should be. We’re aware of the 1% crit reduction per level difference, this is an additional 3% reduction. If we attack mobs of the same level in Berserker Stance, then we are seeing expected crit values. Attacking +3 level mobs while in Defensive or Battle Stance is also giving us expected crit values, after factoring in crit suppression, as can be seen here:

https://github.com/magey/classic-warrior/wiki/Attack-table

In our analysis of 5178 hits, we show that when fighting +3 lvl mobs in Berserker Stance the measured crit chance was ~3% lower than expected on each individual test and also when doing a weighted average of all the tests:

Overall crit chance (weighted average):

• Spell book: 15.61%
• Expected: 12.61% (-3% crit suppression)
• Measured: 9.75% ±0.82%

Additionally, all other attack table results match what what’s expected when fighting +3 level mobs (comparing to our extensive log collection totaling ~15k hits) which further validates these results.

As a control, we also did tests on same level mobs with no weapon skill bonus to see if this bug was caused by some interaction of weapon skill, crit suppression, level difference and the Berserker Stance bonus. In these tests, the measured crit chance was as expected given the tolerances:

Overall crit chance (weighted average):

• Spell book: 17.19%
• Expected: 17.19%
• Measured: 16.93% ±1.22%

The detailed analysis and combat logs of our tests can be found over here:

https://github.com/magey/classic-warrior/issues/17

-magey

[Gus-baelgun (Gus)]

Very interesting Magey.

I wonder if it’s possible that this existed back in 2004-06. If so, I don’t think they should fix/change it. Do you?

[Vokire-cenarion-circle]

@Ekbert-sargeras

In our analysis of 5178 hits, we show that when fighting +3 lvl mobs in Berserker Stance the measured crit chance was ~3% lower than expected on each individual test and also when doing a weighted average of all the tests:

Overall crit chance (weighted average):

• Spell book: 15.61%
• Expected: 12.61% (-3% crit suppression)
• Measured: 9.75% ±0.82%

Additionally, all other attack table results match what what’s expected when fighting +3 level mobs (comparing to our extensive log collection totaling ~10k hits) which further validates these results.

@Aggrend-1483

Critical Strike chance is reduced by 1% per each additional level the target has over the player. (So if you have a 4% chance to crit an at-level target, you have a 1% chance to crit a +3-level target, in both clients.)

@Vokire-cenarion-circle

The way WoW calculates crit rate is over ALL attacks. Crit rate is not based on hits only. In other words, if you have a 5% crit rate, that 5% chance includes misses.

@Vokire-cenarion-circle

+toHit items subtract from your miss%.

So, ignoring all defensive actions (Block/Parry/Dodge/etc…) if I have 20% crit chance, 20% miss chance, and 60% hit chance and I equip an item that gives me +5% toHit and +5% crit, my stats become 25% crit, 15% miss chance, 60% hit chance.

New hit chance = (Original hit%) + (toHit modifiers) - (crit modifiers)
60% + 5% - 5% = 60%

New crit chance = (Original crit%) + (crit modifiers)
20% + 5% = 25%

New miss chance - (Original miss%) - (toHit modifiers)
20% - 5% = 15%

@Aggrend-1483

There is some code in 1.12 that explicitly adds a modifier that causes the first 1% of +hit gained from talents or gear to be ignored against monsters with more than 10 Defense Skill above the attacking player’s Weapon Skill.

This means that the so-called “hit cap” is in effect 9% rather than 8% for a player with 300 Weapon Skill fighting a level 63 monster with a Defense Skill of 315.

If I understand correctly, your rolls should be (against a L63 target as a L60 character without modifiers other than your spell book’s crit%):

91% Hit Chance
15.61-3=12.61% Crit Chance
14% Parry Chance
6.5% Dodge Chance
6.5% Block Chance - Aggrend did not specify this functionality in his posts. Mirayne noted a ~4.5% block
9% chance to miss

The Combat Table - TheorySpot

Combat Table Analysis - TheorySpot

It seems like you’re correct that this may be a bug… I thought originally there was a roll to do miss, dodge, parry, hit first then do crit/glancing blows. I could be misunderstanding something, though.

Edit: for clarity, I thought (prior to this thread due to an incorrect memory) it was a two roll system. When I saidI might be misunderstand something, it wasn’t related to the immediately preceding statement. Sorry for any confusion!

[Mirayne-galakrond]

White hits are one-roll. We can verify this by noting that with enough samples, all the outcomes match their expected probabilities.

Yellow hits are two-roll (for player attacks on mobs). We can verify this by noting critical block events.

The tests we did concerning berserker stance missing crit vs +3 are white hit tests. Again, we are getting expected results for same level mobs, but for +3 we are missing 6% crit when we should only be missing 3% crit.

[Mirayne-galakrond]

I should add that two-roll is a shorthand meaning certain outcomes can overlap (e.g. crit and block) and it also means outcome chances don’t all match up with tooltip values (such as crit). It doesn’t mean you need to actually do two random rolls, it can be done with a single roll and special interpretation but the implementation details aren’t important. Again none of that is relevant to the berserker stance bug since we’re talking white hits.

[Puffymuffins-scilla]

Please fix this, th anks.

[Scyllaxd-tichondrius]

good work gamers. Hopefully blizzard looks into this!

[Puffymuffins-scilla]

Please fix this, th anks.

[Aggrend-1483 (Aggrend)]

Hi All,

We looked into this.

Modifiers to Critical Strike chance are reduced against enemies 3 levels higher than the player-character. We tested a variety of modifiers to Critical Strike, such as: Berserker Stance, the Cruelty talent, and critical strike chance on gear. They all behaved the same as they did in 1.12, so we’ve concluded that there’s no bug here.

Thanks for the report!

[Puffymuffins-scilla]

To be clear, you are stating that berserker stance should give 0 crit when fighting +3mobs? This is on top of the 3% crit supression already known

[Aggrend-1483 (Aggrend)]

I’m not going to get too deep into the specific math on this one, but for the sake of clarity, I’ll say that this is not a per-aura modifier and it is separate than the 3% suppression that is baseline against +3 level creatures. There is a single modifier placed on total Critical Strike gained from auras that increase Crit chance such as those I listed in my last post.

[Puffymuffins-scilla]

Thank you for the response, that clears up a bunch! It took a long time to build the hit tables used in the OP so its appreciated that you responded and that it wasnt all for naught.

Is there any chance you could say what the actual number for the “single modifier placed on total Critical Strike gained from auras” is? Is it always -3% or will it scale with how much additional crit you gain from auras?

[Aggrend-1483 (Aggrend)]

It took a long time to build the hit tables used in the OP so its appreciated that you responded and that it wasnt all for naught.

I can imagine. It was really important to us that we get some sort of response to you before the end of beta.

Is there any chance you could say what the actual number for the “single modifier placed on total Critical Strike gained from auras” is?

Nope

[Flawblure-greymane]

Would you be able to say if this formula existed throughout vanilla or was added later on?

[Lenna-doomhammer]

Looks like people will have to do a bit of science when the game comes out to figure out exactly how the math works, then.

It’d be weird if we found out the crit talents were suppressed and thus weren’t worth nearly as much as we thought, but oh well.

[Roonaru-windrunner]

Wow there’s a lot to unpack in this thread…
Seems like warrior gearing BiS could change since the crit% soft cap will be some unknown number higher than 33% now. To ensure flurry has a 100% to near 100% uptime.
Furthermore it looks like its an additional 1% per mob level reduction of crit from aura buffs. Warrior soft crit cap 36%?

[Ekbert-sargeras]

For anyone interested, we’ve done some extensive research about this since Blizzard’s response which can be found here:

https://github.com/magey/classic-warrior/wiki/Crit-aura-suppression

I’ll quote the TLDR:

Weighted average by number of attacks for all suppression results (without including the 1% aura crit tests which seem to be suppressed entirely) gives ~%4.84 average suppression with a 95% confidence interval of ±0.17%, meaning the suppression to aura crit is likely ~1.8%.

[Commie-tichondrius]

Isn’t it more likely that the crit suppression is a percentage of the additional crit, rather than a flat number? So for higher value of crit, the suppression is greater.

[Vilius-galakrond]

We collected over 60k hits from 10 different testers to arrive at that result. Isn’t it more likely that the theory based on 60k data points is more correct than the theory based on 0 data points?

[Roonaru-windrunner]

Awesome work, has there been any testing with casters? Is the operating assumption that the reduction is the same flat % for them as well?