[BUG] Some item actions do not work - breaks some maps

Hello.

There are several item modifying natives, available both in pure JASS/Lua and GUI. In GUI they are called ‘Item - Set Name’, ‘Item - Set Description’, ‘Item - Set Tooltip’, ‘Item - Set Extended Tooltip’, ‘Item - Set Icon Path’. When they were added, all of them were working perfectly. However, now some of them are broken. ‘Item - Set Description’ and ‘Item - Set Extended Tooltip’ are alright, but ‘Item - Set Name’, ‘Item - Set Tooltip’ do nothing, while ‘Item - Set Icon Path’ does not change the icon but makes the item extended tooltip to display that path instead.

This is quite important since it breaks maps that were relying on these functions to dynamically create/change items, e.g. some RPG maps.

You can find a test map by following the link below.
https://www.hiveworkshop.com/pastebin/ee389f3b2dde26a2d1432cf26829f490.25051

When you start, you can pick up the item lying on the ground with your hero.
It has its default icon/name/description/tooltip/extended tooltip.
There are two triggers that are set up in the map to change these.

Case 1.
To activate the first one, type ‘test’ in the chat.

Expected result:

  • The item’s name is ‘Test Name’ (you can see the name when the item is lying on the ground by selecting it)
  • The item’s description is ‘Test Description’ (you can see the description when the item is lying on the ground by selecting it)
  • The item’s tooltip is ‘Test Tooltip’ (you can see the tooltip when you hover the item while it is in an inventory)
  • The item’s extended tooltip is ‘Test Extended Tooltip’ (you can see the extended tooltip when you hover the item while it is in an inventory)
  • The item’s icon is a ring, its path is ReplaceableTextures\CommandButtons\BTNRingSkull (you can see the icon when you look at the item while it is in an inventory)

Actual result:

  • The item’s name is default - didn’t work
  • The item’s description is ‘Test Description’ - OK
  • The item’s tooltip is default - didn’t work
  • The item’s extended tooltip is ‘ReplaceableTextures\CommandButtons\BTNRingSkull’ - equals to the new icon path
  • The item’s icon is default - didn’t work

Case 2.
To activate the second one, type ‘test2’ in the chat.

Expected result:

  • The item’s name is ‘Test Name’ (you can see the name when the item is lying on the ground by selecting it)
  • The item’s description is ‘Test Description’ (you can see the description when the item is lying on the ground by selecting it)
  • The item’s tooltip is ‘Test Tooltip’ (you can see the tooltip when you hover the item while it is in an inventory)
  • The item’s extended tooltip is ‘Test Extended Tooltip’ (you can see the extended tooltip when you hover the item while it is in an inventory)
  • The item’s icon is a ring, its path is ReplaceableTextures\CommandButtons\BTNRingSkull (you can see the icon when you look at the item while it is in an inventory)

Actual result:

  • The item’s name is default - didn’t work
  • The item’s description is ‘Test Description’ - OK
  • The item’s tooltip is default - didn’t work
  • The item’s extended tooltip is ‘Test Extended Tooltip’ - OK
  • The item’s icon is default - didn’t work
7 Likes